Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

operator: allows to skip placement rules checks (#5458) #5462

Merged
merged 4 commits into from
Sep 27, 2022
Merged

operator: allows to skip placement rules checks (#5458) #5462

merged 4 commits into from
Sep 27, 2022

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5458

What problem does this PR solve?

Issue Number: Close #5401

What is changed and how does it work?

Allows skipping placement rules checks when creating operators.

Check List

Tests

  • Unit test

Code changes

Related changes

  • Need to cherry-pick to the release branch

Release note

Fixed the bug where the Learner Peer of TiFlash Replica might not be created.

@HunDunDM @ti-chi-bot
This is an automated cherry-pick of tikv#5458
775291a 
close tikv#5401

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Aug 31, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 31, 2022
Merged
@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. component/schedule Scheduling logic. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR. labels Aug 31, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Sep 5, 2022
@nolouch
fix test
bfa21fb 
Signed-off-by: nolouch <nolouch@gmail.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 20, 2022
@nolouch nolouch added the require-LGT1 Indicates that the PR requires an LGTM. label Sep 20, 2022
@nolouch
Copy link
Contributor

nolouch commented Sep 20, 2022

/merge

@ti-chi-bot
Copy link
Member Author

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: bfa21fb

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 20, 2022
@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@nolouch
Copy link
Contributor

nolouch commented Sep 21, 2022

/rebuild

@nolouch nolouch removed status/can-merge Indicates a PR has been approved by a committer. require-LGT1 Indicates that the PR requires an LGTM. labels Sep 21, 2022
@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 21, 2022
@nolouch
Copy link
Contributor

nolouch commented Sep 21, 2022

/rebuid

@HunDunDM
fix test
c8393bd 
Signed-off-by: HunDunDM <hundundm@gmail.com>
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Sep 27, 2022
@codecov
Copy link

codecov bot commented Sep 27, 2022 •
edited
Loading

Codecov Report

Base: 74.78% // Head: 74.76% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (c8393bd) compared to base (20e9dda).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@               Coverage Diff               @@
##           release-5.4    #5462      +/-   ##
===============================================
- Coverage        74.78%   74.76%   -0.03%     
===============================================
  Files              265      265              
  Lines            28003    28004       +1     
===============================================
- Hits             20943    20938       -5     
- Misses            5197     5204       +7     
+ Partials          1863     1862       -1
Flag Coverage Δ
unittests 74.76% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/schedule/operator/builder.go 86.89% <100.00%> (+0.43%) ⬆️
server/schedule/operator/create_operator.go 90.37% <100.00%> (ø)
server/region_syncer/server.go 82.69% <0.00%> (-5.13%) ⬇️
pkg/etcdutil/etcdutil.go 84.70% <0.00%> (-3.53%) ⬇️
server/schedulers/random_merge.go 60.00% <0.00%> (-3.34%) ⬇️
client/base_client.go 79.89% <0.00%> (-2.07%) ⬇️
server/tso/allocator_manager.go 62.56% <0.00%> (-1.67%) ⬇️
server/core/storage.go 69.31% <0.00%> (-1.52%) ⬇️
tools/pd-ctl/pdctl/command/hot_command.go 70.62% <0.00%> (-0.70%) ⬇️
server/cluster/cluster.go 82.40% <0.00%> (-0.46%) ⬇️
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 27, 2022
@HunDunDM
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member Author

@HunDunDM: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: c8393bd

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 27, 2022
@ti-chi-bot ti-chi-bot merged commit b599fad into tikv:release-5.4 Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhy1024 lhy1024 lhy1024 approved these changes

@nolouch nolouch nolouch approved these changes

@JmPotato JmPotato JmPotato approved these changes

@disksing disksing Awaiting requested review from disksing

@Yisaer Yisaer Awaiting requested review from Yisaer

Assignees

@HunDunDM HunDunDM

Labels
cherry-pick-approved Cherry pick PR approved by release team. component/schedule Scheduling logic. release-note Denotes a PR that will be considered when it comes time to generate release notes. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ti-chi-bot @nolouch @HunDunDM @JmPotato @lhy1024 @VelocityLight